feat(linter): Added pyproject-flake8 support #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just copied existing flake8 configuration and adapted `cmd`
mfussenegger
reviewed
Nov 8, 2023
There was a problem hiding this comment.
Could you please revert the unrelated style changes?
Is there any reason to use this over https://docs.astral.sh/ruff/ - which is faster and also supports pyproject.toml?
|
Hi, just reverted the changes on style. Regarding the question for reasons against ruff: No reasons against ruff of course. I just did not used it yet. The often mentioned faster speed of ruff wasn't valuable enough for me to change my current setup. Never had issues with the speed of the other linters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I love flake8, and I even more I love configuring it using
pyroject.tomlfiles, which isn't supported by flake8. However there is a package (https://github.com/csachs/pyproject-flake8) which makes this possible.I currently run nvim-lint with a custom configuration for this linter which works well. So I thought it might be a nice idea to add this to upstream also.